Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis CI with GitHub Actions #275

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Jun 4, 2022

Travis CI workflow is no longer working. This PR replaces it with GitHub Actions CI workflow.

The CI workflow checks:

  • npm test with all Node.js LTS releases (v14, v16, v18)
  • npm run lint

Here is an example of workflow result: https://github.com/rhysd/json5/actions/runs/2438401038

@aseemk
Copy link
Member

aseemk commented Jun 13, 2022

Excellent, thank you!

@aseemk aseemk merged commit eaacea9 into json5:master Jun 13, 2022
@aseemk
Copy link
Member

aseemk commented Jun 13, 2022

(@jordanbtucker: let me know if you had any concerns/hesitations with this!)

aseemk added a commit that referenced this pull request Jun 13, 2022
Replace Travis CI with GitHub Actions (#275)
@jordanbtucker
Copy link
Member

Is there a benefit of moving to GitHub Actions over Travis CI? I haven't learned how to use GitHub Actions yet.

@rhysd
Copy link
Contributor Author

rhysd commented Jun 14, 2022

@jordanbtucker
Copy link
Member

I believe we just needed to change the URLs. Travis CI was working up until this merge.

@jordanbtucker
Copy link
Member

@rhysd Thank you for your contribution, however I reverted these changes as I am not ready to switch to a CI platform I'm not familiar with. I fixed the issues with Travis CI (#280, #281), so I will continue using that for the time being.

@rhysd
Copy link
Contributor Author

rhysd commented Jun 15, 2022

OK, I understood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants