-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Travis CI with GitHub Actions #275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Excellent, thank you! |
aseemk
approved these changes
Jun 13, 2022
(@jordanbtucker: let me know if you had any concerns/hesitations with this!) |
aseemk
added a commit
that referenced
this pull request
Jun 13, 2022
Replace Travis CI with GitHub Actions (#275)
Is there a benefit of moving to GitHub Actions over Travis CI? I haven't learned how to use GitHub Actions yet. |
@jordanbtucker Travis CI was no longer working. https://travis-ci.com/json5/json5 is 404. |
I believe we just needed to change the URLs. Travis CI was working up until this merge. |
OK, I understood. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis CI workflow is no longer working. This PR replaces it with GitHub Actions CI workflow.
The CI workflow checks:
npm test
with all Node.js LTS releases (v14, v16, v18)npm run lint
Here is an example of workflow result: https://github.com/rhysd/json5/actions/runs/2438401038