Guard valid content type check against bad Content-Type #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid `undefined method 'start_with?' for nil:NilClass` in `Rack::MediaType` `strip_doublequotes` when given a bad content type. Given: Clients MUST send all JSON:API data in request documents with the header Content-Type: application/vnd.api+json without any media type parameters. Clients MUST ignore any parameters for the application/vnd.api+json media type received in the Content-Type header of response documents. We can just check if the content type == `application/vnd.api+json`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Avoid
undefined method 'start_with?' for nil:NilClassinRack::MediaTypestrip_doublequoteswhen given a bad content type.Additional helpful information
Given:
We can just check if the content type ==
application/vnd.api+json.