Allow number type fields to accept decimal numbers #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment 'number' and 'integer' types are both creating fields that only accept integers. According to the documentation, the intention of 'number' is to accept floating numbers as well: https://github.com/jsonform/jsonform/wiki#supported-types This behaviour was broken in this recent commit: jsonform@b43b465 The proposed change makes 'number' type fields accept decimal numbers again.
|
Looks good ! Thanks @ilamble |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment 'number' and 'integer' types are both creating fields that only accept integers.
According to the documentation, the intention of 'number' is to accept floating numbers as well:
https://github.com/jsonform/jsonform/wiki#supported-types
This behaviour was broken in this recent commit:
b43b465
The proposed change makes 'number' type fields accept decimal numbers again.