Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix selectfieldset behaviour #279

Merged
merged 5 commits into from
Jun 10, 2020
Merged

Fix selectfieldset behaviour #279

merged 5 commits into from
Jun 10, 2020

Conversation

tchapi
Copy link
Member

@tchapi tchapi commented May 29, 2020

When used in an array or tabarray, selectfieldset is buggy.

@tchapi
Fix #276 (WIP)
2bb199b
@tchapi
Fix selectfieldset when sorting an array (Fix #276)
3b9429f 
Basically, reset all active nodes to inactive, and add a
selected attribute on the select.nav to force selection
@tchapi tchapi self-assigned this May 29, 2020
@tchapi tchapi mentioned this pull request May 29, 2020
Closed
This was linked to issues May 29, 2020
selectfieldset doesn't work correctly within an array or tabarray. #276
Closed
selectfieldset doesn't work within a tabarray #44
Closed
@tchapi tchapi marked this pull request as ready for review June 8, 2020 13:26
@tchapi tchapi merged commit 23f853a into master Jun 10, 2020
@tchapi tchapi deleted the bugfix/selectfieldset branch June 10, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tchapi tchapi

Labels
Bug Enhancement
Milestone
No milestone
1 participant
@tchapi