Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context error in formNode.prototype.updateElement #295

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

N30Pr1nc3
Copy link
Contributor

when using "this" inside a _.each() loop "this" refers to the Window variable
in some cases this.el might be set with an element which then is forwardet to updateElement()
this leads to an error
window

when using "this" inside a _.each() loop "this" refers to the Window variable
in some cases this.el might be set with an element which then is forwardet to updateElement()
this leads to an error
@N30Pr1nc3
Copy link
Contributor Author

Hi this is my first atempt to contribute to an open source project. Please let me know if there is anything i can do better.

@tchapi
Copy link
Member

tchapi commented Sep 24, 2020

Hi @N30Pr1nc3 and thanks a lot for your contribution, much appreciated.

I'll have a look when I can and come back to you
Best regards

@tchapi
Copy link
Member

tchapi commented Sep 24, 2020

Do you have any example of a schema that produces an error so I can test your code ? thanks

@N30Pr1nc3
Copy link
Contributor Author

Hm i can not recreate the error in your JsonFormPlayground,
but i can recreate it in our usecse. it seems to occur if i try to create multiple forms. I am verry busy right now, but i will try to provide a codesample next week.

@stale
Copy link

stale bot commented Dec 14, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale label Dec 14, 2020
@tchapi tchapi merged commit 7f8b287 into jsonform:master Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants