Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add navigation tabs #303

Merged
merged 2 commits into from
Dec 22, 2020
Merged

feat: Add navigation tabs #303

merged 2 commits into from
Dec 22, 2020

Conversation

JoshuaFortriede
Copy link
Contributor

This feature is to allow bootstrap navigation tabs to be used to segment form fields onto multiple tabs.

This commit is to add a new feature: Navigation tabs. Navigation tabs are setup at 2 levels. The first is a type "tabs" that has a unique id and an items array. Each item is a object of type "tab" that has a title, which will be displayed as the tab text, and then items. These items are all of the fields to be presented on this tab.

Test HTML and JS pages have also been created under the tabs-nav namespace. This namespace was choosen so that it would not conflict with other "tab" namespaces that are currently present. It also is informative as it signifies the purpose of the tabs to be navigation, while still keeping the namespace brief.

This commit is to add a new feature: Navigation tabs. Navigation tabs are setup at 2 levels. The first is a type "tabs" that has a unique id and an items array. Each item is a object of type "tab" that has a title, which will be displayed as the tab text, and then items. These items are all of the fields to be presented on this tab.

Test HTML and JS pages have also been created under the tabs-nav namespace. This namespace was choosen so that it would not conflict with other "tab" namespaces that are currently present. It also is informative as it signifies the purpose of the tabs to be navigation, while still keeping the namespace brief.
@tchapi
Copy link
Member

tchapi commented Dec 14, 2020

Hi @JoshuaFortriede and thanks for your work on this

I have little time these days to review PR but I will try to have a look soon. Could you provide a working example that I would include on the playground pages, too ?

@JoshuaFortriede
Copy link
Contributor Author

@tchapi, I have added an example on the playground page. Let me know if there is anything else that I can do to help.

@tchapi tchapi merged commit 04de7b9 into jsonform:master Dec 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants