Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to selectively disable array draggable by form configuration #348

Merged
merged 8 commits into from
May 31, 2021

Conversation

sdetweil
Copy link
Contributor

fixes #336

@tchapi
Copy link
Member

tchapi commented May 30, 2021

Hi @sdetweil

Can you fix the rogue spaces that this PR adds (line 261 for instance, etc — see https://github.com/jsonform/jsonform/pull/348/files), and also provide an example schema so I can test this ?

Thanks a lot for your work !

@tchapi
Copy link
Member

tchapi commented May 30, 2021

EDIT: I corrected the spaces — you can merge master into your branch again — or rebase (same for your other PRs)

@sdetweil
Copy link
Contributor Author

sdetweil commented May 30, 2021

attached file for playground

two cases, with drag enabled.

  1. if u have a field with an ace editor in an array, and click in it, you are stuck in drag mode
    only way out is to right click, then exit the right click. shouldn't happen

  2. if drag is enabled, tabs in tabarray are draggable, but in my app that operation doesn't mean anything, so its should be tuned off, but drag is enable form wide. need something selective... drag is set to false in the form attached (selectively)

schema.json.txt

@tchapi tchapi merged commit e787193 into jsonform:master May 31, 2021
@sdetweil sdetweil deleted the draggable branch June 3, 2021 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

turn off draggable on tabarray and array
2 participants