Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectfieldset: fix select style #361

Merged
merged 1 commit into from
Jun 10, 2021
Merged

selectfieldset: fix select style #361

merged 1 commit into from
Jun 10, 2021

Conversation

joelguittet
Copy link
Contributor

Hello

We can see on the selectfieldsetexample (https://jsonform.github.io/jsonform/playground/index.html?example=fields-selectfieldset) that the select field used to perform the selection between the item has not the proper style:

selectfieldset

To avoid complex style with css stuff, I suggest to add the class "form-control" to the select field generated by the lib. See git diff of this PR.

Tested with my own project OK but I let you check it and verify it has no unwanted impact, I guess there isn't.

Joel

@tchapi tchapi self-assigned this Jun 10, 2021
@tchapi tchapi merged commit 496e64a into jsonform:master Jun 10, 2021
@tchapi
Copy link
Member

tchapi commented Jun 10, 2021

Thanks a lot @joelguittet !

@joelguittet
Copy link
Contributor Author

Thanks for being so quick to get it merged !
I see the example is also updated, looks nice now :-)

Joel

@joelguittet joelguittet deleted the fix-select-style-in-selectfieldset branch June 10, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants