Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on empty key in context #251

Merged
merged 1 commit into from Feb 23, 2019

Conversation

fsteeg
Copy link
Member

@fsteeg fsteeg commented Feb 14, 2019

I think with this we can resolve #141.

The actual issue of producing invalid output from Jena has been fixed in Jena as described by @afs in #141 (comment). This pull request adds throwing an error as mentioned by @ansell in #141 (comment).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 89.027% when pulling f406471 on fsteeg:141-errorOnEmptyKey into 47eaff4 on jsonld-java:master.

@fsteeg
Copy link
Member Author

fsteeg commented Feb 22, 2019

@ansell @tristan, how do you feel about merging this? Let me know if you have any doubts.

In general, should I assign you (one of you? both?) when I open a pull request? And should I rather push to branches in this repo (not my fork) so that you can push changes into proposed pull requests?

@ansell
Copy link
Member

ansell commented Feb 23, 2019

If we need to make changes, we can pull locally and merge. Sorry I haven't had a chance to look at this so far. It looks good to me.

@ansell ansell merged commit a1075bd into jsonld-java:master Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Invalid JSON-LD if Jena defines an "" prefix
3 participants