New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue #293 : Add com.google.thirdparty to shading #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Ansell <p_ansell@yahoo.com>
fsteeg
approved these changes
Sep 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at https://issues.apache.org/jira/browse/STORM-538 (linked from #293), this fix looks good to me (but have no way to actually verify for jsonld-java).
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Nov 14, 2020
- cf jsonld-java/jsonld-java#294 - TODO more tests and configurations
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Dec 13, 2020
- cf jsonld-java/jsonld-java#294 - TODO more tests and configurations
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Dec 26, 2020
- upgrade jsonld-java to allow using a local cache of @context - cf jsonld-java/jsonld-java#294 - TODO more tests and configurations - use the provided context in API call for compaction in every concerned service - ensure core context comes last when compacting - do not re-add core context if already referenced by a context provided in the query
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Dec 27, 2020
- upgrade jsonld-java to allow using a local cache of @context - cf jsonld-java/jsonld-java#294 - TODO more tests and configurations - use the provided context in API call for compaction in every concerned service - ensure core context comes last when compacting - do not re-add core context if already referenced by a context provided in the query
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Dec 27, 2020
- upgrade jsonld-java to allow using a local cache of @context - cf jsonld-java/jsonld-java#294 - TODO more tests and configurations - use the provided context in API call for compaction in every concerned service - ensure core context comes last when compacting - do not re-add core context if already referenced by a context provided in the query
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Jan 1, 2021
- upgrade jsonld-java to allow using a local cache of @context - cf jsonld-java/jsonld-java#294 - TODO more tests and configurations - use the provided context in API call for compaction in every concerned service - ensure core context comes last when compacting - do not re-add core context if already referenced by a context provided in the query
bobeal
added a commit
to stellio-hub/stellio-context-broker
that referenced
this pull request
Jan 4, 2021
- upgrade jsonld-java to allow using a local cache of @context - cf jsonld-java/jsonld-java#294 - TODO more tests and configurations - use the provided context in API call for compaction in every concerned service - ensure core context comes last when compacting - do not re-add core context if already referenced by a context provided in the query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where google have bundled some guava code into a different top level package to the rest of guava.
Fixes #293
Signed-off-by: Peter Ansell p_ansell@yahoo.com