Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #293 : Add com.google.thirdparty to shading #294

Merged
merged 1 commit into from Sep 15, 2020

Conversation

ansell
Copy link
Member

@ansell ansell commented Sep 9, 2020

This fixes an issue where google have bundled some guava code into a different top level package to the rest of guava.

Fixes #293

Signed-off-by: Peter Ansell p_ansell@yahoo.com

Signed-off-by: Peter Ansell <p_ansell@yahoo.com>
@ansell ansell requested review from fsteeg and dr0i September 9, 2020 20:21
@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.317% when pulling bed5196 on hotfix/issue-293-guava-shading into 9d000fe on master.

Copy link
Member

@fsteeg fsteeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at https://issues.apache.org/jira/browse/STORM-538 (linked from #293), this fix looks good to me (but have no way to actually verify for jsonld-java).

@ansell ansell merged commit 8001da1 into master Sep 15, 2020
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Nov 14, 2020
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Dec 13, 2020
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Dec 26, 2020
- upgrade jsonld-java to allow using a local cache of @context
  - cf jsonld-java/jsonld-java#294
  - TODO more tests and configurations
- use the provided context in API call for compaction in every concerned service
- ensure core context comes last when compacting
- do not re-add core context if already referenced by a context provided in the query
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Dec 27, 2020
- upgrade jsonld-java to allow using a local cache of @context
  - cf jsonld-java/jsonld-java#294
  - TODO more tests and configurations
- use the provided context in API call for compaction in every concerned service
- ensure core context comes last when compacting
- do not re-add core context if already referenced by a context provided in the query
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Dec 27, 2020
- upgrade jsonld-java to allow using a local cache of @context
  - cf jsonld-java/jsonld-java#294
  - TODO more tests and configurations
- use the provided context in API call for compaction in every concerned service
- ensure core context comes last when compacting
- do not re-add core context if already referenced by a context provided in the query
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Jan 1, 2021
- upgrade jsonld-java to allow using a local cache of @context
  - cf jsonld-java/jsonld-java#294
  - TODO more tests and configurations
- use the provided context in API call for compaction in every concerned service
- ensure core context comes last when compacting
- do not re-add core context if already referenced by a context provided in the query
bobeal added a commit to stellio-hub/stellio-context-broker that referenced this pull request Jan 4, 2021
- upgrade jsonld-java to allow using a local cache of @context
  - cf jsonld-java/jsonld-java#294
  - TODO more tests and configurations
- use the provided context in API call for compaction in every concerned service
- ensure core context comes last when compacting
- do not re-add core context if already referenced by a context provided in the query
@ansell ansell deleted the hotfix/issue-293-guava-shading branch December 11, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.13.1 causes error with InternetDomainName of Guava
3 participants