Fixed returned @context issues when the context is a remote context #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbreak
force-pushed
the
compact_with_iri
branch
2 times, most recently
from
066c3db
to
0148848
Compare
umbreak
force-pushed
the
compact_with_iri
branch
from
0148848
to
47a595a
Compare
umbreak
changed the title
umbreak
force-pushed
the
compact_with_iri
branch
from
06f9ccb
to
b784f3f
Compare
umbreak
changed the title
umbreak
changed the title
|
As far as I have seen in the spec and in the tests done in the playground, the passed context is the one that has to be provided as a result, not the resolved one or anything else. It still passes the tests from the W3C suite, so I assume there is no further problem with it. |
umbreak
force-pushed
the
compact_with_iri
branch
from
99b35ab
to
e87a1f3
Compare
umbreak
force-pushed
the
compact_with_iri
branch
from
e87a1f3
to
99f8ae0
Compare
dr0i
added a commit
to dr0i/jsonld-java
that referenced
this pull request
Sep 22, 2020
dr0i
requested changes
Sep 22, 2020
dr0i
requested changes
Sep 22, 2020
core/src/main/java/com/github/jsonldjava/core/JsonLdProcessor.java
Outdated
Show resolved
Hide resolved
|
I've added the changes from your PR in my latest commit |
ansell
reviewed
Sep 22, 2020
umbreak
force-pushed
the
compact_with_iri
branch
from
83a6eb1
to
4894387
Compare
|
Looks good, thanks. Will release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #295
Fixes #184
Fixes #297
Fixes #298