Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AttributeError decoding OrderedDict #33

Closed
jaraco opened this issue Apr 17, 2013 · 5 comments
Closed

AttributeError decoding OrderedDict #33

jaraco opened this issue Apr 17, 2013 · 5 comments

Comments

@jaraco
Copy link
Contributor

jaraco commented Apr 17, 2013

The traceback speaks for itself.

Python 2.7.4 (default, Apr  6 2013, 19:55:15) [MSC v.1500 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import jsonpickle
>>> import collections
>>> jsonpickle.decode(jsonpickle.encode(collections.OrderedDict()))
OrderedDict()
>>> jsonpickle.decode(jsonpickle.encode(collections.OrderedDict(a=1)))
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "c:\python\lib\site-packages\jsonpickle-0.4.1dev-py2.7.egg\jsonpickle\__init__.py", line 325, in decode
    return j.restore(json.decode(string))
  File "c:\python\lib\site-packages\jsonpickle-0.4.1dev-py2.7.egg\jsonpickle\unpickler.py", line 123, in restore
    instance[k] = value
  File "c:\python\lib\collections.py", line 59, in __setitem__
    root = self.__root
AttributeError: 'OrderedDict' object has no attribute '_OrderedDict__root'
@jaraco
Copy link
Contributor Author

jaraco commented Apr 17, 2013

I'm happy to put together a patch for this issue. I plan to hold off until it's clear that pull requests will be accepted and released.

@davvid
Copy link
Member

davvid commented Apr 20, 2013

@johnpaulett would you mind granting me commit access to the jsonpickle repo? You added me to the organization a long time ago but I was never granted commit access ;-) I'd be happy to start merging the pull requests that both fix issues and pass all tests in preparation for the next minor release.

We can save all topics that would break backwards-compatibility for a major release, but first we'll want to get the least-controversial features released so that folks can start using them.

@johnpaulett
Copy link
Contributor

@davvid Done (sorry, I did not realize you lacked that access)

@davvid
Copy link
Member

davvid commented Jun 2, 2013

Nicely done @jaraco. Is this issue safe to close now?

@jaraco
Copy link
Contributor Author

jaraco commented Jun 2, 2013

Yes. Thanks for all the help with pull requests.

@jaraco jaraco closed this as completed Jun 2, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants