Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix jack son style #413

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ATICA-pln
Copy link

Hotfix with solution for #412

(I apologize in advance I was not able to run the tests, any help on the error will be much appreciated - when installing numpy in the virtual environment I got: AttibuteError: fcompiler)

…cedId attibute to each new object next to the ReferencedClass attibute
@stefan6419846
Copy link

Your changeset is much too large as you replaced all the indentation of four whitespace characters with tabulators. Additionally, having a quick glance at the code, tests are still missing and pyId is no valid PEP8 variable/parameter name.

Is the wheel package installed inside your virtual environment? Otherwise, pip will try to install numpy from source, while you can use the existing wheels if you install the wheel package beforehand.

@Theelx
Copy link
Contributor

Theelx commented Oct 26, 2022

Stefan is correct on all of those issues. Please run black . and isort . --profile black from the command line on the code for proper formatting. You can install them with pip install black and pip install isort. We also need tests for this, so make some example data and tests, and then run the tests with pytest . in the command line of the repo's home directory.

@ATICA-pln
Copy link
Author

Thank you for your feedback. I will try to run the tests (I am not very experienced yet).
In the meanwhile, I confirm that the proposed implementation is compatible with Java Jackson library (https://github.com/FasterXML/jackson) - we have been able to fully code and decode a JSON file with object references exchanging it back and forth between Java and Python :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants