Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop pinning back setuptools #424

Closed
bmw opened this issue Dec 12, 2022 · 4 comments
Closed

Stop pinning back setuptools #424

bmw opened this issue Dec 12, 2022 · 4 comments

Comments

@bmw
Copy link

bmw commented Dec 12, 2022

# setuptools >= 59 seems to break something with distutils on 3.11
requires = ["setuptools>=42,<59", "wheel", "setuptools_scm[toml]>=3.4.1"]
works in the short term, but it excludes you and your users from any setuptools fixes/improvements.

One example of this is older versions of setuptools can raise deprecation warnings on Python 3.11 due to their use of the module sre_constraints which was deprecated in Python 3.11 and is something they fixed in setuptools 62.3.0.

@Theelx
Copy link
Contributor

Theelx commented Dec 13, 2022

Sorry, I thought I had removed the pin, it's back from when scipy wasn't building on GHA with setuptools >=59, but it's not necessary anymore.

@gbdlin
Copy link

gbdlin commented Dec 14, 2022

Can a 3.0.1 version be released with this pin removed?

@Theelx
Copy link
Contributor

Theelx commented Dec 16, 2022

Yeah sure, I'll try to do it tomorrow morning

@Theelx
Copy link
Contributor

Theelx commented Dec 16, 2022

3.0.1 has been released! https://pypi.org/project/jsonpickle/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants