fix(NumberConstraint): force positive value on first arg

Resolves #315 - `multipleOf` is inconsistent, fails for negative numbers
jsonrainbow · Oct 10, 2016 · c669b57 · c669b57
1 parent 0bbaac8
commit c669b57
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 0 deletions.
diff --git a/.gitignore b/.gitignore
@@ -7,3 +7,4 @@ coverage
 .settings
 composer.lock
 docs-api
+phpunit.xml
diff --git a/src/JsonSchema/Constraints/NumberConstraint.php b/src/JsonSchema/Constraints/NumberConstraint.php
@@ -69,6 +69,7 @@ public function check($element, $schema = null, JsonPointer $path = null, $i = n
 
     private function fmod($number1, $number2)
     {
+        $number1 = abs($number1);
         $modulus = fmod($number1, $number2);
         $precision = abs(0.0000000001);
         $diff = (float)($modulus - $number2);

diff --git a/tests/Constraints/NumberAndIntegerTypesTest.php b/tests/Constraints/NumberAndIntegerTypesTest.php
@@ -95,6 +95,19 @@ public function getValidTests()
                     "type": "object",
                     "properties": {
                         "number": {"type": "number"}
+
+                    }
+                }'
+            ),
+            array(
+                '{"number": -49.89}',
+                '{
+                    "type": "object",
+                    "properties": {
+                        "number": {
+                          "type": "number",
+                          "multipleOf": 0.01
+                        }
                     }
                 }'
             )