Issue-414: Allow The Option of T or space for Date time. #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erayd
requested changes
Apr 12, 2017
src/JsonSchema/Rfc3339.php
Outdated
| @@ -23,7 +23,9 @@ public static function createFromString($string) | |||
| $microseconds = $matches[2] ?: '.000000'; | |||
| $timeZone = 'Z' !== $matches[3] ? $matches[4] . ':' . $matches[5] : '+00:00'; | |||
|
|
|||
| $dateTime = \DateTime::createFromFormat('Y-m-d\TH:i:s.uP', $dateAndTime . $microseconds . $timeZone, new \DateTimeZone('UTC')); | |||
| $dateFormat = strpos($dateAndTime, 'T') === false ? 'Y-m-d H:i:s.uP' : 'Y-m-d\TH:i:s.uP'; | |||
There was a problem hiding this comment.
Could this check strpos($dateAndTime, 'T') === 10) please? That way it won't be tripped up by someone passing a 'T' elsewhere in the string.
There was a problem hiding this comment.
(Although that said, I don't think that this is a huge issue, because timezone codes aren't currently allowed, so things like 'PST' will not be an issue at present. So if you'd rather leave it the way it is, that's fine too.)
|
Also, could you please change the base for this PR to 6.0.0-dev. I'll backport it for 5.2.x as soon as it's merged. |
Merged
HunterEl
force-pushed
the
issue-414
branch
3 times, most recently
from
efd5a9f
to
a8c849c
Compare
|
@erayd done. |
|
@bighappyface Your turn now :-). |
|
Backported for 5.2.1 in f375f0b. |
bighappyface
pushed a commit
that referenced
this pull request
May 16, 2017
* Split $objectDefinition into $schema and $properties (#411) Object validation attempts to use a single variable to store both the object definition, and its properties. This causes validation to be incomplete where "properties" is not set, but "additionalProperties" is. This commit fixes both bugs in issue #353. * Issue-414: Allow The Option of T or space for Date time. (#415) * Testcase for minProperties with properties defined (#416) + Fix Test * Tweak phpdocumentor dependency to avoid install conflicts (#421) * [BUGFIX] Cast empty schema arrays to object (#409) * Cast root to object * Use function_exists to allow polyfill compatibility * Move array->object conversion to SchemaConstraint & SchemaStorage Fixes issue #408 * fix bug when applying defaults for array items when the schema is for (#405) all items and add support for minItems when applying defaults * [BUGFIX] Split "uri" format into "uri" & "uri-reference", fix meta-schema bug (#419) * Split "uri" format into "uri" and "uri-reference" * Correct format for id & $ref in draft-03/04 meta-schemas See json-schema-org/JSON-Schema-Test-Suite#177 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see Github Issue: #414
This PR is to allow for a
Tor space when providing date times to JSON Schema.Let me know if there is anything different you would like me to do or if this is not the direction you would like this project to go in.
Thank you!