Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test on PHP 7.4 and HHVM 3 #605

Merged
merged 2 commits into from
Dec 20, 2019
Merged

Test on PHP 7.4 and HHVM 3 #605

merged 2 commits into from
Dec 20, 2019

Conversation

GrahamCampbell
Copy link
Contributor

No description provided.

@GrahamCampbell
Copy link
Contributor Author

Tests are failing due to code style, not relating to this PR.

@erayd
Copy link
Contributor

erayd commented Dec 20, 2019 •
edited

Thanks for this :-).

Code style issue in CI is known - the settings for php-cs-fixer need fixing; agree it's unrelated.

@erayd erayd merged commit 9153066 into jsonrainbow:master Dec 20, 2019
@GrahamCampbell GrahamCampbell deleted the patch-1 branch December 20, 2019 10:07
@Ayesh Ayesh mentioned this pull request May 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erayd erayd erayd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@GrahamCampbell @erayd