Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request a theme #7

Closed
thomasdavis opened this issue Apr 1, 2020 · 11 comments
Closed

Request a theme #7

thomasdavis opened this issue Apr 1, 2020 · 11 comments

Comments

@thomasdavis
Copy link
Member

If you want to add an official theme please make a pull request where you add it to ./functions/package.json once accepted, the branch will automatically be deployed to firebase using Github actions.

@thomasdavis
Copy link
Member Author

Also try to include a screenshot or live demo in the PR.

@sundowndev
Copy link

I get redirected to this issue even for using official themes resume serve --port 8080 --theme paper

@Poslovitch
Copy link

Same here, with resume serve --theme onepage

@lfarci
Copy link

lfarci commented Oct 10, 2020

I just got redirected here too after executing resume serve --theme paper resume.json.

Edit: my bad, after installing the jsonresume-theme-paper npm package globally, I was able to successfully use the official theme.

@thomasdavis
Copy link
Member Author

Hrmmmm can you paste full output

Try to install theme globally on your comp

Npm I -g jsonresume-theme-paper

@mubarakshow
Copy link

mubarakshow commented Oct 21, 2020

Solved
if you tried to install in a project rather than globally, you can do the following to run.

  1. go into the node_modules folder
    cd node_module
  2. go into the installed theme folder
    cd jsonresume-theme-{theme name}
  3. add your resume.json file to the root of the theme
  4. run this command: resume serve

@TARIQvs
Copy link

TARIQvs commented Nov 17, 2020

Even the above solution didn't work for me. But global installation is a help.

@thomasdavis
Copy link
Member Author

Going to take a look tonight to see if there is any better solutions or at least add some helper text.

@cphoover
Copy link

cphoover commented Jun 7, 2021

I thought it was supposed to find custom themes you are developing local to the root of the project (outside of node_modules)

@jackkeller
Copy link

How are updates to themes handled? If I submit a PR for one but then update it at a later date is that a new PR with a version bump?

@thomasdavis
Copy link
Member Author

@jackkeller yes, the new PR just requires to change the version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants