Skip to content
This repository has been archived by the owner on Jun 4, 2020. It is now read-only.

Supported Themes #12

Closed
thomasdavis opened this issue Jun 27, 2019 · 45 comments
Closed

Supported Themes #12

thomasdavis opened this issue Jun 27, 2019 · 45 comments

Comments

@thomasdavis
Copy link
Member

If you would like a theme supported on the official registry/theme servers please post below

e.g. "I would like to see jsonresume-theme-awesome"

@bvosk
Copy link

bvosk commented Aug 19, 2019

Please add my theme, jsonresume-theme-pumpkin.

Thank you!

@thomasdavis
Copy link
Member Author

@bvosk Great work. I've added it -> https://registry.jsonresume.org/thomasdavis?theme=pumpkin

@lechuckcaptain
Copy link

Dear @thomasdavis would you be so kind to add also add my theme, jsonresume-theme-cora to the official registry?

Thank you!

@thomasdavis
Copy link
Member Author

@lechuckcaptain no worries. Theme looks great, added -> https://registry.jsonresume.org/thomasdavis?theme=cora

@2xAA
Copy link

2xAA commented Aug 30, 2019

Hey @thomasdavis, would you be able to add my theme?
https://www.npmjs.com/package/jsonresume-theme-wraypro

Thanks!

@thomasdavis
Copy link
Member Author

@2xAA https://registry.jsonresume.org/thomasdavis?theme=wraypro done

@souvikmaji
Copy link

Hi @thomasdavis, https://www.npmjs.com/package/jsonresume-theme-elegant-jali is a great looking theme. Can you please add it?

@thomasdavis
Copy link
Member Author

@souvikmaji looks like it includes puppeteer which is too large of a dependency for us to include. Can you move it to dev dependencies?

@wahidshafique
Copy link

@joeytall
Copy link

joeytall commented Oct 9, 2019

Hi @thomasdavis , I know you are a busy man, but can you take a quick minute add my theme, I made it very clean and professional.
https://www.npmjs.com/package/jsonresume-theme-joeytall
Would really appreciate it!

@thomasdavis
Copy link
Member Author

hey @joeytall, I'm hesitant to include themes that are modifications of previous ones. Let me think about it for a bit

@joeytall
Copy link

joeytall commented Oct 9, 2019

Most themes supported so far are modifications of others(mainly elegant), so I don't see that as a problem.

@cedricdelpoux
Copy link

Could you make a list of supported themes? I'm not sure to understand how it works. For example, I'm able to use the papirus theme but it's not listed here and not the official listing neither

@Suncatcher
Copy link

Suncatcher commented Nov 1, 2019

Support this, I also want to see list of available themes. Any theme I put throws unsupported. Where can I obtain a list of themes on server?

@thomasdavis
Copy link
Member Author

Hi guys, I just pushed up a simply endpoint to list the current packages that the registry is deployed to handle -> https://registry.jsonresume.org/themes

It will automatically update as new ones are added.

@EmaSuriano
Copy link
Member

Hello, I would like to see jsonresume-theme-standard-resume.

@thomasdavis
Copy link
Member Author

Thanks @EmaSuriano, I do like that theme. Added.

https://registry.jsonresume.org/thomasdavis?theme=standard-resume

@veeravn
Copy link
Contributor

veeravn commented Jan 1, 2020

@thomasdavis Could you please add this theme https://github.com/veeravn/jsonresume-theme-tan-responsive.

@nickimola
Copy link

please add my theme:
https://www.npmjs.com/package/jsonresume-theme-nl-flat
thank you

@HeidiHansen
Copy link

Where can I preview these themes? I'd really like to preview additional ones that aren't listed at https://jsonresume.org/themes/ but I'm not finding this anywhere.

@veeravn
Copy link
Contributor

veeravn commented Feb 9, 2020

You will have to install the ones that aren't listed at jsonresume.org into you computer and run them locally using nodejs

@HeidiHansen
Copy link

HeidiHansen commented Feb 9, 2020

So I take this as a 'no'. It's really unfortunate that there aren't screenshots for these- It's cumbersome (if you want to try out many different ones) to install them before previewing. =/

@ricosmall
Copy link

@thomasdavis Could you please add my theme jsonresume-theme-apage?Thanks.

@Snuggle
Copy link

Snuggle commented Mar 4, 2020

I would love to see jsonresume-theme-rocketspacer by @rocketspacer, please!

@GordonRudman
Copy link

I would like to see jsonresume-theme-kwan-linkedin

@GordonRudman
Copy link

Please add my theme:
https://www.npmjs.com/package/jsonresume-theme-kwan-linkedin
Thank you

@thomasdavis
Copy link
Member Author

@Snuggle I've added Rocket Spacer, looks good -> https://registry.jsonresume.org/theme/rocketspacer

@ricosmall Currently getting an error in your theme when running against default resume.json -> https://registry.jsonresume.org/theme/apage

@thomasdavis
Copy link
Member Author

@HeidiHansen You are correct, it is annoying. Hopefully getting something out tonight to view examples of themes.

@mathieudutour
Copy link

@thomasdavis Could add https://github.com/mathieudutour/jsonresume-theme-github to the registry? Thank 🙏

@thomasdavis
Copy link
Member Author

@mathieudutour good job, just getting the error

TypeError: Cannot read property 'filter' of undefined
    at getExperiences (/srv/functions/node_modules/jsonresume-theme-github/index.js:218:10)
    at Object.Handlebars.registerHelper (/srv/functions/node_modules/jsonresume-theme-github/index.js:261:23)

You just need to defend against when someone doesn't have fields in their resume

https://github.com/mathieudutour/jsonresume-theme-github/blob/master/index.js#L218

The user doesn't have experience array.

@mathieudutour
Copy link

Ah right, should be fine now

@thomasdavis
Copy link
Member Author

@mathieudutour Did you publish to npm again?

@thomasdavis
Copy link
Member Author

Oh you did, ignore

@thomasdavis
Copy link
Member Author

@mathieudutour Looks to be working -> https://registry.jsonresume.org/thomasdavis?theme=github

I really liked the pinned attribute too, I think it might make a lot of sense to merge into the schema.

@thomasdavis
Copy link
Member Author

@mathieudutour there is a 30 second render time that I can't figure out

@mathieudutour
Copy link

Hum not sure. Maybe the html minifier?

@veeravn
Copy link
Contributor

veeravn commented Mar 31, 2020

@thomasdavis Could you please add this theme https://github.com/veeravn/jsonresume-theme-tan-responsive

Thank You

@thomasdavis
Copy link
Member Author

@veeravn
Copy link
Contributor

veeravn commented Mar 31, 2020

@thomasdavis I noticed that the size of the resume generated from my theme is a little off, so I was wondering what version of the theme that was published to the npm registry was used to generate the resume.

@thomasdavis
Copy link
Member Author

@veeravn checkout the functions/package.json to see which version of your theme is active.

Anyone who wants a theme added can also submit a PR with their theme added to the package.json

@veeravn
Copy link
Contributor

veeravn commented Apr 1, 2020

@thomasdavis I didn't see my theme listed in the package.json file so I added it with the correct version and submitted this PR #14

@thomasdavis
Copy link
Member Author

@veeravn My bad, the new repo is https://github.com/jsonresume/registry-functions/

I've gotta make a new issue on that repo...

@veeravn
Copy link
Contributor

veeravn commented Apr 1, 2020

@veeravn My bad, the new repo is https://github.com/jsonresume/registry-functions/

I've gotta make a new issue on that repo...

I created a PR in the registry-functions repo

@thomasdavis
Copy link
Member Author

@veeravn deploying now, thanks!

@thomasdavis
Copy link
Member Author

This repo will be deprecated from now on, continue discussion in the registry repo -> jsonresume/registry-functions#7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests