Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): fix theme package lookup #367

Merged
merged 2 commits into from
Jul 5, 2020

Conversation

rbardini
Copy link
Contributor

Normalize theme package name before passing to program actions, and delegate module resolution to Node.

@rbardini rbardini changed the title fix(theme): Fix theme package lookup fix(theme): fix theme package lookup Jun 27, 2020
index.js Show resolved Hide resolved
Copy link
Contributor

@antialias antialias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but I recommend addressing my comment about using a custom options processor instead of explicitly invoking getThemeName.

@antialias antialias merged commit bfcfb9c into jsonresume:master Jul 5, 2020
@rbardini rbardini deleted the fix-theme-lookup branch July 21, 2020 22:33
@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@hkdobrev
Copy link

I believe this PR broke a documented behaviour of the resume serve command.

When developing a theme one should be available to run resume serve inside the theme folder and that should load index.js from the current folder. Currently, it loads the default theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants