Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolvability issues with phone and e-mail field design. #4

Closed
inadarei opened this issue Jul 7, 2014 · 1 comment
Closed

Evolvability issues with phone and e-mail field design. #4

inadarei opened this issue Jul 7, 2014 · 1 comment

Comments

@inadarei
Copy link

inadarei commented Jul 7, 2014

In any message format design it's a good idea to make things that can change be data elements, rather than structural elements. Changing structural elements breaks things, data elements provide evolvability.

Phone and e-mail fields have a lot of variance. People have different types of phones, emails and they don't necessarily limit them to "work" and "personal". Making such assumptions is wrong.

Instead following is what you could do.

This:

email: [
{"type": "work", "value" : string}, // e.g. thomas@facebook.com
{"type": "personal", "value" : string} // thomas@gmail.com
],

is more evolvable than this:

email: {
work: string, // e.g. thomas@facebook.com
personal: string // thomas@gmail.com
}

the same is true for the phone field.

@rolandnsharp
Copy link
Member

Thanks for this suggestion, I'll just transfer this over to resume-schema for issues.
jsonresume/resume-schema#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants