fix: use denormalize theme name for server request

[cukejianya]

When using the command resume server --theme [insert them name], the request got back a 400 error with the error message posted down below.

The PR creates a denormalizeTheme function in the builder 'index.js' file (mostly for readability) and uses that function to denormalize the theme name from 'jsonresume-theme-even' to 'even'.

[thomasdavis]

@cukejianya Great work on the PR. This is to suppose both --theme jsonresume-theme-even and --theme even ?

[rbardini]

Wouldn't it be better to handle this in the theme server instead?

[thomasdavis]

@rbardini yeah thinking about it more, I'd rather people just use the api one way, which is to leave off jsonresume-theme-

And I think the resume users should do the same.

Unless someone has a good reason that they require this I will be closing for now.

[cukejianya]

@thomasdavis Hey, sorry for the late response. This PR is for a bug. It's not to add new functionality. Currently, the functionality you're talking about already exist. So when a user passes in --theme jsonresume-theme-even or --theme even, the cli currently normalizes that theme (regardless of how the user inputed it) as jsonresume-theme-even.

Because of that, when passing the string "jsonresume-theme-even" to the server, the API apparently concatenates that string to "jsonresume-theme-" resulting in the API looking for "jsonresume-theme-jsonresume-theme-even"

This PR is to denormalize the theme from jsonresume-theme-even to even, so when we POST it to the API, the API concatenates the string "even" to "jsonresume-theme-", thus finding the correct theme "jsonresume-theme-even"

[rbardini]

Indeed, if we intend to use it with a single format (leaving off jsonresume-theme-), then this PR is relevant.

I was thinking the other way around: making the API flexible to accept both normalized (e.g. jsonresume-theme-even) and denormalized (e.g. even) themes, like the CLI does.

[thomasdavis]

Aha my bad, will merge the PR but keep the API less flexible.

Thanks @cukejianya

[github-actions]

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀