Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a photo to the bio section #29

Closed
michaeldk opened this issue Jul 7, 2014 · 20 comments
Closed

Add a photo to the bio section #29

michaeldk opened this issue Jul 7, 2014 · 20 comments

Comments

@michaeldk
Copy link

As much as it said that physical appearances shouldn't influence a resume, I believe the choice should be left to the user whether or not he wants to use a photo in his resume.

@thomasdavis
Copy link
Member

Agreed. Some templates might choose to use gravatar for photos, though the specification could contain an alternative field

@borgateo
Copy link

borgateo commented Jul 7, 2014

+1
Optional photo would be a good addition.

@ocram
Copy link
Contributor

ocram commented Jul 9, 2014

+1, has been suggested again here and this is a possible solution

@osg
Copy link

osg commented Jul 10, 2014

+1 for optional.

1 similar comment
@DonDebonair
Copy link
Member

+1 for optional.

@thomasdavis
Copy link
Member

Need need some suggestions for the field name.

  • picture
  • profilePicture
  • pictureUrl
  • avatar
  • mugshot
  • selfie

@osg
Copy link

osg commented Jul 10, 2014

+1 profilePicture

-1 for avatar, mugshot, and selfie

@osg
Copy link

osg commented Jul 10, 2014

Rationale: If I use a picture of myself, it is not an avatar. Mugshot and selfie reduce the level of professionalism, and are not as easily understood by multiple language backgrounds/cultures.

@DonDebonair
Copy link
Member

In #80 "pictureUrl" is used, but I think that's superfluous. As far as I know, there's not other way to provide a picture in a JSON document, than specifying an URL to a picture (aside maybe from a base64 encoded data-url?). So the best options in my opinion are "profilePicture" or just "picture".
I assume your last two suggestions are more in jest @thomasdavis ;) And "avatar" signifies a small picture to be used on a forum or other online community, not a real photo.

@thomasdavis
Copy link
Member

I'm sad to see no consensus on selfie =(

My vote goes to picture, I like to think the spec can get away with being
casual in that sense.

On Thu, Jul 10, 2014 at 5:25 PM, Daan Debie notifications@github.com
wrote:

In #80 #80 "pictureUrl"
is used, but I think that's superfluous. As far as I know, there's not
other way to provide a picture in a JSON document, than specifying an URL
to a picture (aside maybe from a base64 encoded data-url?). So the best
options in my opinion are "profilePicture" or just "picture".
I assume your last two suggestions are more in just @thomasdavis
https://github.com/thomasdavis ;) And "avatar" signifies a small
picture to be used on a forum or other online community, not a real photo.


Reply to this email directly or view it on GitHub
#29 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@thomasdavis
Copy link
Member

Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future.

@ocram
Copy link
Contributor

ocram commented Jul 10, 2014

picture is definitely the best name. Updated the pull request as well.

Optional, of course. But we don't have marked optional and required fields yet, anyway, right?

@osg
Copy link

osg commented Jul 10, 2014

The only case where picture is not specific enough (and profilePicture might be) is if there is more than one picture on a resume. (I cannot think of such an instance, can you?)

Note: Specs in general are not casual; content based on specs has more flexibility in that regard.

@DonDebonair
Copy link
Member

I cannot think of more picture occurrences in resumes.

@ocram
Copy link
Contributor

ocram commented Jul 11, 2014

Can't think of such an instance, either. Many people will not even have a single picture, and I've never seen a resume with two pictures. That should be fine.

@thomasdavis
Copy link
Member

Okay, I think picture will suffice for now. Last comments end in 30mins then I will mark this as ready.

The picture field will be added to the bio field as type string

string is a primitive type of JSON schema, I'm still learning more about JSON schema as time goes on so we will adhere to just using string until I know all the repercussions of using type url

@DonDebonair
Copy link
Member

I do think we should choose between string and url before v1 is released :) I'd love to make a PR for this one, but I promised my wife we'd leave for the beach in 5 minutes. So I'm off until further notice ;)

@thomasdavis
Copy link
Member

Sure, we will do another PR at a later date that corrects all the types.
Shouldn't be too much of a problem.

On Sat, Jul 12, 2014 at 7:57 PM, Daan Debie notifications@github.com
wrote:

I do think we should choose between string and url before v1 is released
:) I'd love to make a PR for this one, but I promised my wife we'd leave
for the beach in 5 minutes. So I'm off until further notice ;)


Reply to this email directly or view it on GitHub
#29 (comment)
.

Thomas Davis
http://thomasdav.is

VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com

@ocram
Copy link
Contributor

ocram commented Jul 12, 2014

Is this still working? (seems so) #80

@DonDebonair
Copy link
Member

I think we can close this as #80 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants