Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonical source URL #82

Closed
wants to merge 2 commits into from
Closed

Canonical source URL #82

wants to merge 2 commits into from

Conversation

ocram
Copy link
Contributor

@ocram ocram commented Jul 9, 2014

As suggested here: #28

As suggested here: #28
@ocram ocram mentioned this pull request Jul 9, 2014
@DonDebonair
Copy link
Member

I like it, but maybe we could go for a simpler url. The fact that it's a root element, makes it clear enough that it defines the location where the document itself can be found (IMHO).

@ocram
Copy link
Contributor Author

ocram commented Jul 10, 2014

@dandydev One could definitely do that. The term canonical/official could be used in the description to make it clear.

@wdoekes
Copy link

wdoekes commented Jul 12, 2014

+1 to just url, but I don't have a simple answer to the questions raised by @thomasdavis in #28.

@osg
Copy link

osg commented Jul 12, 2014

+1 for url

@DonDebonair
Copy link
Member

@mwaclawek could you update your PR to rename the field to url?

@ocram
Copy link
Contributor Author

ocram commented Jul 13, 2014

@dandydev updated

@DonDebonair
Copy link
Member

Can @thomasdavis chime in if it's ok to merge this?

@erming
Copy link
Contributor

erming commented Sep 2, 2014

Ping @thomasdavis

Should we accept the url property?

@stp-ip
Copy link
Member

stp-ip commented Dec 24, 2015

LGTM. I would say it's save to merge. Only the description could be finetuned later on.

@osg
Copy link

osg commented Dec 24, 2015

Rarely do people come back to get to the documentation bits. How about an action verb with a solid description before merging.

@chrisdotcode
Copy link
Member

I think canonical is better than url - the former has explicit semantic meaning, meaning "latest version can be found here" while the latter doesn't.

Besides, what if the canonical version for someone's resume in in some book somewhere?

This should also be optional. Non-hackers who don't host their own stuff might just using JSON Resume as a transit format and have no canonical.

@olivif
Copy link
Collaborator

olivif commented Dec 24, 2015

@chrisdotcode +1 for making it optional.

@opensourcegrrrl +1 for updated description although I have no idea what would be better.

Given the changes requested, we might need a new PR (or updates to this one if @mwaclawek is still around)

@aloisdg
Copy link
Contributor

aloisdg commented Dec 25, 2015

I personaly prefer "latest". As far as I know, it is widely used (jQuery or readthedocs for example).

By the way, should we talk here or on #28?

@chrisdotcode
Copy link
Member

PRs are transient, issues are definitive. Let's all move to #28.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants