Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add facebook video #63

Merged
merged 8 commits into from
Oct 5, 2016
Merged

Add facebook video #63

merged 8 commits into from
Oct 5, 2016

Conversation

iamandrewluca
Copy link

No description provided.

@KrisBraun
Copy link

Thanks! Even though the autoplay param is in the code, it's not autoplaying and there's no play button overlay, so it's not obvious that a second click is needed to play the video.

@iamandrewluca
Copy link
Author

I will take a look and maybe will find some docs about this.

@iamandrewluca iamandrewluca changed the title Add facebook viddeo Add facebook video Sep 26, 2016
now autoplay is workig
@iamandrewluca
Copy link
Author

iamandrewluca commented Sep 27, 2016

@KrisBraun now autoplay it works, and when is false, play button is showed. Just found another video url.
There is a test that fails. check first link in facebook tests test/functional/uri.html

@KrisBraun
Copy link

Thanks so much, @iamandrewluca. Works great for me!

@jsor
Copy link
Owner

jsor commented Oct 5, 2016

Hi,

thanks for the pull request (and sorry for the late response). Could you rename the handler from facebook to facebookvideo since it only handles videos and not images etc. (which could be implemented in a separate handler)?

Maybe facebookimage also will be implemented in a future release
@jsor jsor merged commit f3407f3 into jsor:master Oct 5, 2016
@jsor
Copy link
Owner

jsor commented Oct 5, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants