Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not add redundant name/main #239

Closed
guybedford opened this issue Nov 11, 2014 · 2 comments
Closed

Do not add redundant name/main #239

guybedford opened this issue Nov 11, 2014 · 2 comments

Comments

@guybedford
Copy link
Member

From systemjs/systemjs#246.

Given a package.json (for example):

{
  "name": "foo",
  "main": "bar.js",
  "jspm": {
    "dependencies": { "baz": "asda" }
  }
}

When I jspm install, the package.json is overrwritten. name and main properties are copied from the root object added to the jspm object:

{
  "name": "foo",
  "main": "bar.js",
  "jspm": {
    "name": "foo",
    "main": "bar.js",
    "dependencies": { "baz": "asda" }
  }
}

Does jspm need to add these? Surely they are redundant?

@OliverJAsh
Copy link

Thanks for moving across!

@guybedford
Copy link
Member Author

Fixed in 7ee062f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants