Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install scoped package with binaries #2512

Closed
wants to merge 1 commit into from
Closed

Conversation

jbanety
Copy link
Contributor

@jbanety jbanety commented Mar 25, 2020

When I install a scoped package with binaries I'll get this error :

$ jspm install  @mapbox/geojson-rewind
err (jspm) Internal Error: Unhandled promise rejection.
Error: ENOENT: no such file or directory, open '[...]/jspm_packages/.bin/@mapbox/geojson-rewind'

jspm install command don't stripe scope in path so the destination folder doesn't exists.
My PR is to remove the scope with a regexp before writing file.

When I install a scoped package with binaries I'll get this error :
```bash
$ jspm install  @mapbox/geojson-rewind
err (jspm) Internal Error: Unhandled promise rejection.
Error: ENOENT: no such file or directory, open '[...]/jspm_packages/.bin/@mapbox/geojson-rewind'
```
jspm install command don't stripe scope in path so the destination folder doesn't exists.
My PR is to remove the scope with a regexp before writing file.
@guybedford
Copy link
Member

Thanks for the PR. This is originally generated in https://github.com/jspm/jspm-cli/blob/master/src/install/package.ts#L449 so I think we should add the scope check there, which is simply then name[0] === '@' ? name.slice(name.indexOf('/')) : name or something along those lines.

Just to warn you, due to a lack of user interest in jspm 2, the entire version is considered deprecated and will be abandoned soon.

@jbanety
Copy link
Contributor Author

jbanety commented Mar 27, 2020

Hi @guybedford,
I'm sad to hear that.
It was very promising for the future of web app.
What will be the alternatives?

@guybedford
Copy link
Member

I'm working on a jspm 3 version which will entirely move away from trying to recreate local package management, since it seems that combination of approach is too complex for most users to grasp.

@jbanety
Copy link
Contributor Author

jbanety commented Mar 27, 2020 via email

@guybedford
Copy link
Member

If you're interested in trying out / contributing to jspm 3, it should be ready for further testing within the next month.

@jbanety
Copy link
Contributor Author

jbanety commented Mar 27, 2020 via email

@fusionstrings
Copy link
Contributor

What are the ways one can be part of JSPMv3 testing, once and when it's available @guybedford .

@guybedford
Copy link
Member

@jbanety @fusionstrings I can invite you both to the private testing for jspm 3 when it is ready if you like.

@jbanety
Copy link
Contributor Author

jbanety commented Mar 28, 2020 via email

@fusionstrings
Copy link
Contributor

@jbanety @fusionstrings I can invite you both to the private testing for jspm 3 when it is ready if you like.

I will feel extremely privileged @guybedford 👍 .

@guybedford guybedford closed this Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants