Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

render importmap #17

Merged
merged 4 commits into from
Jan 23, 2022
Merged

render importmap #17

merged 4 commits into from
Jan 23, 2022

Conversation

fusionstrings
Copy link
Contributor

No description provided.

@JayaKrishnaNamburu
Copy link
Member

JayaKrishnaNamburu commented Jan 22, 2022

Hey, looks cool. But can we make it resolve by opening generator.jspm.io instead of here.

@fusionstrings fusionstrings marked this pull request as draft January 22, 2022 10:53
@fusionstrings
Copy link
Contributor Author

main issue here still needed to solve is that detail element closes on update

@fusionstrings
Copy link
Contributor Author

Hey, looks cool. But can we make it resolve by opening generator.jspm.io instead of here.

How do we do it?
Looked into it but couldn't follow.

@guybedford
Copy link
Member

The generator URL hash construction is implemented here - https://github.com/jspm/generator.jspm.io/blob/main/src/statehash.js.

@fusionstrings
Copy link
Contributor Author

The layout is wider now to accommodate open detail elements.

@fusionstrings fusionstrings marked this pull request as ready for review January 23, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants