Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

maintain_aspect_ratio parameter not working in image-* plugins #1172

Closed
becky-gilbert opened this issue Nov 5, 2020 · 0 comments · Fixed by #1174
Closed

maintain_aspect_ratio parameter not working in image-* plugins #1172

becky-gilbert opened this issue Nov 5, 2020 · 0 comments · Fixed by #1174
Assignees
Labels
Milestone

Comments

@becky-gilbert
Copy link
Collaborator

In the image-* plugins, it seems like resizing an image by specifying either the height or width (via stimulus_height or stimulus_width) with maintain_aspect_ratio: false doesn't work - the image is resized according to the specified dimension, but the other dimension is changed as well and the aspect ratio is maintained. Instead, when maintain_aspect_ratio is false, the unspecified height or width dimension should be the image's original value, and the image should be stretched/compressed accordingly.

I'll fix this in the same pull request that will add the render_on_canvas option to the image plugins (to fix the image flashing issue in Firefox: #891, #969).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant