Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect default value documentation for jspsych-same-different plugin #1879

Closed
nikbpetrov opened this issue Jun 8, 2021 · 5 comments · Fixed by #1880
Closed

Incorrect default value documentation for jspsych-same-different plugin #1879

nikbpetrov opened this issue Jun 8, 2021 · 5 comments · Fixed by #1880
Assignees
Projects
Milestone

Comments

@nikbpetrov
Copy link
Contributor

nikbpetrov commented Jun 8, 2021

The default value in the documentation of the jspsych-same-different-html for the first_stim_duration and second_stim_duration says 1000, while within the plugin file it is set to null, meaning the stimuli display until a key press (while this is not indicated to the user by default).

I imagine the default values in the plugin file need to be updated to 1000 instead of null.

Edit: ditto for the jspsych-same-different-image documentation and plugin file.

@nikbpetrov nikbpetrov changed the title Incorrect default value documentation for jspsych-same-different-html plugin Incorrect default value documentation for jspsych-same-different plugin Jun 8, 2021
@becky-gilbert
Copy link
Collaborator

Thanks very much for flagging this error @nikbpetrov! We'll fix it ASAP.

@becky-gilbert becky-gilbert added this to the 7.0 milestone Jun 8, 2021
@becky-gilbert becky-gilbert reopened this Jun 8, 2021
@becky-gilbert
Copy link
Collaborator

Ah, just saw your pull request that fixes this. Thanks!

@becky-gilbert becky-gilbert added this to In progress in 7.0 Jun 10, 2021
becky-gilbert added a commit that referenced this issue Jun 10, 2021
…s-fix

Fixes stim duration default values in same-different plugins #1879
@becky-gilbert becky-gilbert linked a pull request Jun 10, 2021 that will close this issue
@becky-gilbert
Copy link
Collaborator

Closed via PR #1880 (1436132)

@becky-gilbert becky-gilbert moved this from In progress to Done in 7.0 Jun 10, 2021
@becky-gilbert
Copy link
Collaborator

@nikbpetrov FYI, I just added your name to the contributors.md file. Please submit a pull request with changes to this file if you want to be listed differently or if I made any errors.

Thanks again! 😃

@nikbpetrov
Copy link
Contributor Author

@nikbpetrov FYI, I just added your name to the contributors.md file. Please submit a pull request with changes to this file if you want to be listed differently or if I made any errors.

Thanks again! 😃

Thanks @becky-gilbert ! All looks good. Glad I could help. I hope I can contribute more substantially soon (working on #647 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
7.0
Done
Development

Successfully merging a pull request may close this issue.

2 participants