-
-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect default value documentation for jspsych-same-different plugin #1879
Comments
Thanks very much for flagging this error @nikbpetrov! We'll fix it ASAP. |
Ah, just saw your pull request that fixes this. Thanks! |
…s-fix Fixes stim duration default values in same-different plugins #1879
@nikbpetrov FYI, I just added your name to the contributors.md file. Please submit a pull request with changes to this file if you want to be listed differently or if I made any errors. Thanks again! 😃 |
Thanks @becky-gilbert ! All looks good. Glad I could help. I hope I can contribute more substantially soon (working on #647 ) |
The default value in the documentation of the jspsych-same-different-html for the
first_stim_duration
andsecond_stim_duration
says 1000, while within the plugin file it is set tonull
, meaning the stimuli display until a key press (while this is not indicated to the user by default).I imagine the default values in the plugin file need to be updated to 1000 instead of
null
.Edit: ditto for the
jspsych-same-different-image
documentation and plugin file.The text was updated successfully, but these errors were encountered: