Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug with audio playing and progress bar #648

Closed
jodeleeuw opened this issue Jul 31, 2019 · 3 comments · Fixed by #1115
Closed

bug with audio playing and progress bar #648

jodeleeuw opened this issue Jul 31, 2019 · 3 comments · Fixed by #1115
Labels
bug
Milestone
6.2

Comments

@jodeleeuw
Copy link
Member

has to do with Audio HTML5 element and ready to play event.
@jodeleeuw jodeleeuw added this to the 6.2 milestone Jul 31, 2019
@jodeleeuw
Copy link
Member Author

(bug throws an error, but doesn't create any performance issues)

becky-gilbert added a commit to becky-gilbert/jsPsych that referenced this issue Oct 12, 2020
@becky-gilbert
fixes html5 audio progress bar error - jspsych#648
7410fd0
@becky-gilbert becky-gilbert mentioned this issue Oct 12, 2020
Merged
@becky-gilbert becky-gilbert linked a pull request Oct 12, 2020 that will close this issue
Fixes #648 - bug with audio and progress bar #1115
Merged
becky-gilbert added a commit that referenced this issue Oct 20, 2020
@becky-gilbert
Merge pull request #1115 from becky-gilbert/audio-bug
790aafd 
Fixes #648 - bug with audio and progress bar
@becky-gilbert becky-gilbert mentioned this issue Oct 20, 2020
Closed
@becky-gilbert becky-gilbert reopened this Nov 19, 2020
@becky-gilbert
Copy link
Collaborator

Apparently the pull request didn't completely fix this problem - see here. I think we should leave this issue open but not let it hold up the 6.2 release (assuming it's still just a console error and there are no reports of problems with the audio loading/playing).

@jodeleeuw jodeleeuw mentioned this issue Nov 25, 2020
Closed
@becky-gilbert
Copy link
Collaborator

The problem raised in the discussion post above produces the same console error, but has a slightly different cause. So I've opened a different issue to track it (#1262) and I'm closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
6.2
Development

Successfully merging a pull request may close this issue.

Fixes #648 - bug with audio and progress bar becky-gilbert/jsPsych
2 participants
@jodeleeuw @becky-gilbert