Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

throw a useful error message when the timeline is empty #853

Closed
jodeleeuw opened this issue Jul 9, 2020 · 2 comments
Closed

throw a useful error message when the timeline is empty #853

jodeleeuw opened this issue Jul 9, 2020 · 2 comments
Milestone

Comments

@jodeleeuw
Copy link
Member

this just got me. forgot to push anything onto the timeline and the error was cryptic at best.

@jodeleeuw jodeleeuw added this to the 6.2 milestone Jul 9, 2020
@aridyckovsky
Copy link
Contributor

Is the error also thrown when the timeline is undefined? Only when the timeline is defined as an array object but remains empty timeline.length == 0? Or both? It might be helpful to create verbose error messages for each, especially given the core nature of timelines.

@jodeleeuw
Copy link
Member Author

Verbose errors for both seems like the right way to go.

(This is a general problem across the project that needs attention. Lots of places where we could provide more descriptive error messages.)

jodeleeuw added a commit that referenced this issue Oct 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants