survey-html-form: add autofocus parameter #1072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Users can provide the id of an element to focus on when the slide is displayed. While HTML5 has an autofocus parameter it is not universal and not all browsers support it. This solution should work across browsers and is more in keeping with the jsPsych object style. Issue jspsych#1062
|
Thanks @chrisbrickhouse! I agree that the autofocus attribute isn't reliable and calling .focus() seems to work better. Thanks also for showing how this parameter works in the plugin's example file! Somewhere around line 71 in the plugin, I think there needs to be a check that an element with the ID specified by trial.autofocus exists on the page, otherwise line 72 will produce an error. Perhaps there should be a console warning if no element with this ID is found. What do you think? If you agree, feel free to update the pull request or I can merge as is and then make changes. |
When the autofocus parameter is set, check that the specified element exists in the DOM and check that the specified ID is unique. If there is not exactly 1 element with the given ID, warn the user about unexpected behavior.
|
Perfect, thanks very much! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can provide the id of an element to focus on when the
slide is displayed. While HTML5 has an autofocus parameter
it is not universal and not all browsers support it. This
solution should work across browsers and is more in keeping
with the jsPsych object style.
Issue #1062