New tests for image-button-response and image-keyboard-response #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jodeleeuw I've now merged this fix for this (pull request #1028) so these tests should be passing. They pass for me locally. Not sure why they show as failing here? |
becky-gilbert
requested review from
jodeleeuw
and removed request for
jodeleeuw
|
Odd, they work for me locally too. I wonder if there is some subtle difference with the build environment on the server. We could try updating jest to the newest version, though that would potentially create issues. |
|
I updated to Jest 26.6 and re-ran the tests but they still fail. Is it possible that some piece of the code isn't merged into this branch? Grasping at straws here... |
…e-plugin-tests sync with jspsych master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #1014 - one new test in each of the plugin test files that checks for console.warn after running a trial with
response_ends_trial: falseandtrial_duration: null. I've checked that these tests currently fail and pass after merging the fix in pull request #1028.@jodeleeuw can you have a look at this please? If you're happy with these tests then I can add them to other relevant plugin test files.