New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to free-sort plugin #1203
Conversation
updates to free-sort plugin, new functionality
Becky, how do I review this code? |
@pjkohler But I was really just thinking that you could have a quick look through the file changes and comment here if you have any feedback. Or if you click on the 'Files changed' tab at the top of this pull request, I think Github also shows a 'Review changes' button that you can use to make comments. (Or maybe you can only see that button if I request a review from you first?) And if you wanted to, you could also pull this code down locally and run the example file to see my changes. But I realize that might be a bit too time-consuming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good to me.
…tton and sort area
These are the changes that @pjkohler made (#1018) and that I merged into this branch.
I made some additional changes:
-parameterized things like borders/colors/text
-added the option to display images in random locations inside the sort area, which was the old plugin behavior
-fixed the tests
-minor tweaks/updates to the docs
-more examples
I put this in PR because it's quite a lot of changes. I'd be grateful if @jodeleeuw @pjkohler or anyone else could have a look please!