Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement migration errors #2245

Merged
merged 2 commits into from Nov 5, 2021
Merged

Implement migration errors #2245

merged 2 commits into from Nov 5, 2021

Conversation

bjoluc
Copy link
Member

@bjoluc bjoluc commented Oct 19, 2021

Closes #2217

I'd be happy if you could read over the messages and see if they make sense to you @jodeleeuw @becky-gilbert @chrisbrickhouse. The MigrationError class appends a sentence with a link to the migration docs page to each message.

@changeset-bot
Copy link

changeset-bot bot commented Oct 19, 2021

🦋 Changeset detected

Latest commit: 1410345

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jspsych Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@becky-gilbert becky-gilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! I ❤️ that you've included messages for all of the renamed getter functions.

packages/jspsych/src/JsPsych.ts Show resolved Hide resolved
packages/jspsych/src/migration.ts Show resolved Hide resolved
Copy link
Contributor

@chrisbrickhouse chrisbrickhouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, add some ideas for expanding this scheme in future versions.

packages/jspsych/src/JsPsych.ts Show resolved Hide resolved
packages/jspsych/src/migration.ts Show resolved Hide resolved
packages/jspsych/src/migration.ts Show resolved Hide resolved
@jodeleeuw jodeleeuw merged commit ca4fd61 into main Nov 5, 2021
@jodeleeuw jodeleeuw deleted the migration-errors branch November 5, 2021 22:24
@github-actions github-actions bot mentioned this pull request Nov 5, 2021
@github-actions github-actions bot mentioned this pull request Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Built in warnings to help people migrate to v7?
4 participants