Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove crypto module dependency #2540

Merged
merged 3 commits into from
Mar 13, 2022
Merged

Remove crypto module dependency #2540

merged 3 commits into from
Mar 13, 2022

Conversation

bjoluc
Copy link
Member

@bjoluc bjoluc commented Mar 13, 2022

Since we cannot get rid of this in seedrandom/seedrandom, I have included another PRNG (seedrandom/lib/alea, due to its performance and small size) that doesn't mention crypto. No breaking change, since v7.2.0 doesn't work anyway 馃檲

@changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2022

馃 Changeset detected

Latest commit: f26d276

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
jspsych Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bjoluc bjoluc requested a review from jodeleeuw March 13, 2022 14:29
Copy link
Member

@jodeleeuw jodeleeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Thank you for the quick check and fix here! LMK if you want me to take over and work on the rest of the release now that you've done the hard part 馃榿

@bjoluc
Copy link
Member Author

bjoluc commented Mar 13, 2022

That'd be great, thanks! 馃殌

@jodeleeuw jodeleeuw merged commit 9c6ebac into main Mar 13, 2022
@github-actions github-actions bot mentioned this pull request Mar 13, 2022
@bjoluc bjoluc deleted the fix-seedrandom branch March 13, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants