Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add video trial requiring a keyboard response #622

Merged
merged 1 commit into from
Jul 11, 2019

Conversation

designatednerd
Copy link
Contributor

Hello! I was helping my fiancée get this up and running for an experiment she's doing, and figured this would be a useful thing to contribute back.

I cobbled this together by combining bits of jspsych-video.js and jspsych-image-keyboard-response.js. I have approximately zero idea what I'm doing with Javascript beyond copy-pasta, so unfortunately there's no tests.

Any feedback would be most welcome.

@jodeleeuw
Copy link
Member

Thanks a bunch for submitting this. I'm a bit swamped at the moment, but I will take a look when I can. I'd love to include this in the 6.1 release that I'm working on right now. It'd be great to also have a jspsych-video-button-response and jspsych-video-slider-response plugin to complete the set.

@jodeleeuw jodeleeuw added this to the 6.1 milestone Jun 28, 2019
@jodeleeuw jodeleeuw merged commit 6be8601 into jspsych:master Jul 11, 2019
@jodeleeuw jodeleeuw mentioned this pull request Jul 11, 2019
@designatednerd
Copy link
Contributor Author

Thank you!

@jodeleeuw jodeleeuw mentioned this pull request Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants