fix: emit .d.ts and .js files into _dist folder and other fixes #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marvinhagemeister
previously approved these changes
Apr 29, 2024
Base automatically changed from
fix_npm_tarball_generation_when_slow_types
to
main
April 29, 2024 17:07
lucacasonato
force-pushed
the
npm_tarball_dist_folder
branch
from
d0769b9
to
09bb81d
Compare
lucacasonato
changed the title
lucacasonato
dismissed
marvinhagemeister’s stale review
PR changed significantly
- Emit .d.ts files and .js files into the `_dist` folder, so that TypeScript doesn't end up probing for the wrong file - Do not reference `.d.ts` files from other `.d.ts` files using the `.d.ts` extension, because otherwise tsc gets upset. So we instead use `.js` (even if the file does not exist!) - Emit source maps in separate files, because TSC doesn't understand embedded source maps
lucacasonato
force-pushed
the
npm_tarball_dist_folder
branch
from
c0df2ca
to
4ec33a9
Compare
marvinhagemeister
approved these changes
Apr 30, 2024
|
Looks like this change broke my package base16-tailwind since it depends on the |
|
@donovanglover Can you file a new issue for that? It's much easier for us to track issues in issues, rather then comments on closed PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
To make this work, also bans publishing packages containing a top level folder called
_dist.Also we now do not reference
.d.tsfiles from other.d.tsfiles using the.d.tsextension, because otherwise tsc gets upset. So we instead use.js(even if the file does not exist!)Also we emit source maps into separate files, because TSC doesn't understand embedded source maps.