Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay/Snippets] Test group-based snippets in 'Before sending mail from worker' behaviors from relay #625

Closed
jstanden opened this issue Mar 12, 2018 · 6 comments
Assignees
Projects
Milestone

Comments

@jstanden
Copy link
Owner

Source: https://twitter.com/mattmartincouk/status/973008952618348545

@jstanden jstanden created this issue from a note in Maintenance (In Development) Mar 12, 2018
@jstanden jstanden added this to the 8.3.2 milestone Mar 15, 2018
@iammattmartin
Copy link

To make this a bit more serious, it turns out when replying via the API, the same thing happens.

We can only send mail via the GUI to have this data properly populated.

@iammattmartin
Copy link

To add more to this, when you send a first response via the API (i.e first is outbound), the data IS populated. It just appears to be on non-initial emails.

@jstanden jstanden modified the milestones: 8.3.2, 8.3.3 Mar 21, 2018
@iammattmartin
Copy link

iammattmartin commented Mar 24, 2018

Further info.

We set a custom field on a group called "Public", which will show the matching groups in our customer portal.

We have a bot that will set the referenced signature where it gets the group snippets but I have determined that even the bot logic cannot see the group which is why the group snippet data is probably blank.

(Added {{group_custom_27}} to output the data and it is blank when message sent from worker via the API, relay and mobile interface but is populated when via the GUI).

@jstanden
Copy link
Owner Author

Looking into this now.

@jstanden jstanden self-assigned this Mar 26, 2018
@jstanden
Copy link
Owner Author

The issue here appears to be that if you don't explicitly provide a group_id or bucket_id on a reply from the API, we aren't defaulting them. The UI always set them because they're in the form. With the relay or mobile UI you didn't even have the option.

I tweaked the code to default to the ticket's current values when not provided.
cerb-625.patch.txt

@jstanden
Copy link
Owner Author

Fixed in 8.3.3

Maintenance automation moved this from In Development to Completed! Mar 26, 2018
jstanden added a commit that referenced this issue Mar 26, 2018
…PI, relay, or mobile UI. When a `group_id` or `bucket_id` wasn't explicitly provided, group-based placeholders weren't available in bot behaviors. The main web interface always provides these values.

Fixes #625
jstanden added a commit to wgm/cerb that referenced this issue Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Maintenance
  
Completed!
Development

No branches or pull requests

2 participants