New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing documentation for .stdev and .variance #123
Conversation
@trevnorris If I could impose on you to give a brief howto on merging things into a version branch / master / &c, that'd be much appreciated - don't want to mess it up. Thanks! |
@@ -708,7 +708,7 @@ less or equal than (if `kind == 'weak'`) score. Default is `'weak'`. | |||
|
|||
**histogram( dataArray, [numBins] )** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're here, mind changing this to:
**histogram( dataArray[, numBins] )**
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
actually, nm it. seems the file needs a pass of fixes anyway.
LGTM Now, merge tips:
Let me know if you have any questions, or if you'd like me to take care of it. |
Great. I'll do it asap, I would like to get the hang of it so you don't need to do all the merging. Thanks! Is there anything in particular that needs to be done to get the documentation onto the github pages, or does that update automatically? I've never used github pages. |
@jamescgibson I just generate the documentation and update the assets in https://github.com/jstat/jstat.github.com I'll add you as a maintainer to that as well. |
I think I have everything set up, but when I try to push the new commit up to the 1.1 branch I get
Not sure if I'm doing something wrong or what - I'm seeing a cc: @trevnorris |
@jamescgibson What's the output of |
I can |
@jamescgibson sorry about that. Forgot to flip the read access to read/write access in the settings. My bad. Try again. |
PR-URL: #123 Reviewed-by: Trevor Norris <trev.norris@gmail.com>
No worries! I think I got it. Closed by 376eb4a |
Awesome. Congrats on landing your first patch. :-) |
Fix problem reported via the Google Group. The tests were correct; the functions were incorrectly documented.