Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing documentation for .stdev and .variance #123

Closed
wants to merge 1 commit into from

Conversation

jamescgibson
Copy link
Member

Fix problem reported via the Google Group. The tests were correct; the functions were incorrectly documented.

@jamescgibson
Copy link
Member Author

@trevnorris If I could impose on you to give a brief howto on merging things into a version branch / master / &c, that'd be much appreciated - don't want to mess it up.

Thanks!

@@ -708,7 +708,7 @@ less or equal than (if `kind == 'weak'`) score. Default is `'weak'`.

**histogram( dataArray, [numBins] )**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're here, mind changing this to:

**histogram( dataArray[, numBins] )**

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, nm it. seems the file needs a pass of fixes anyway.

@trevnorris
Copy link
Member

LGTM

Now, merge tips:

  • Check fields in previous commits (e.g. 7fb9fe0) for a couple of the required fields. Make sure to use the full URL in PR-URL:, and add my info in Reviewed-by:.
  • Make sure commit message and message body are free of typo's. Commit message max of 50 chars, and message body max line length of 72 chars.
  • Since this is only a single commit can edit the commit message by doing git commit --amend and edit the commit message that way.

Let me know if you have any questions, or if you'd like me to take care of it.

@jamescgibson
Copy link
Member Author

Great. I'll do it asap, I would like to get the hang of it so you don't need to do all the merging. Thanks!

Is there anything in particular that needs to be done to get the documentation onto the github pages, or does that update automatically? I've never used github pages.

@trevnorris
Copy link
Member

@jamescgibson I just generate the documentation and update the assets in https://github.com/jstat/jstat.github.com I'll add you as a maintainer to that as well.

@jamescgibson
Copy link
Member Author

I think I have everything set up, but when I try to push the new commit up to the 1.1 branch I get

ERROR: Permission to jstat/jstat.git denied to jamescgibson.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.

Not sure if I'm doing something wrong or what - I'm seeing a Contributor tag on the Github website, but no dice from the CLI.

cc: @trevnorris

@trevnorris
Copy link
Member

@jamescgibson What's the output of git remote -v?

@jamescgibson
Copy link
Member Author

jamescgibson    https://github.com/jamescgibson/jstat.git (fetch)
jamescgibson    https://github.com/jamescgibson/jstat.git (push)
origin  git@github.com:jstat/jstat.git (fetch)
origin  git@github.com:jstat/jstat.git (push)

I can fetch just fine, for what it's worth.

@trevnorris
Copy link
Member

@jamescgibson sorry about that. Forgot to flip the read access to read/write access in the settings. My bad. Try again.

jamescgibson added a commit that referenced this pull request Jan 17, 2015
PR-URL: #123
Reviewed-by: Trevor Norris <trev.norris@gmail.com>
@jamescgibson
Copy link
Member Author

No worries! I think I got it. Closed by 376eb4a

@trevnorris
Copy link
Member

Awesome. Congrats on landing your first patch. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants