Fixed MD4 to only dispose internal buffers if disposing == true

jstedfast · Apr 15, 2023 · 20e041d · 20e041d
1 parent 99576c4
commit 20e041d
Showing 1 changed file with 20 additions and 18 deletions.
diff --git a/MailKit/Security/Ntlm/MD4.cs b/MailKit/Security/Ntlm/MD4.cs
@@ -379,24 +379,26 @@ public byte[] TransformFinalBlock (byte[] inputBuffer, int inputOffset, int inpu
 
 		void Dispose (bool disposing)
 		{
-			if (buffered != null) {
-				Array.Clear (buffered, 0, buffered.Length);
-				buffered = null;
-			}
-
-			if (state != null) {
-				Array.Clear (state, 0, state.Length);
-				state = null;
-			}
-
-			if (count != null) {
-				Array.Clear (count, 0, count.Length);
-				count = null;
-			}
-
-			if (x != null) {
-				Array.Clear (x, 0, x.Length);
-				x = null;
+			if (disposing) {
+				if (buffered != null) {
+					Array.Clear (buffered, 0, buffered.Length);
+					buffered = null;
+				}
+
+				if (state != null) {
+					Array.Clear (state, 0, state.Length);
+					state = null;
+				}
+
+				if (count != null) {
+					Array.Clear (count, 0, count.Length);
+					count = null;
+				}
+
+				if (x != null) {
+					Array.Clear (x, 0, x.Length);
+					x = null;
+				}
 			}
 		}