Expose signature creation time and expiration time as guint64 #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a very conservative change that attempts to address jstedfast#68. It avoids changing the memory layout of the GMimeSignature object, since it might accessed directly by a user who doesn't use the function interface. It takes a different approach to indicating a failure than the established (time_t)-1 mechanism, to encourage safer use. Signed-off-by: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
jstedfast
reviewed
Dec 4, 2019
| g_return_val_if_fail (GMIME_IS_SIGNATURE (sig), FALSE); | ||
| g_return_val_if_fail (created != NULL, FALSE); | ||
| g_return_val_if_fail (sig->created != (time_t)-1, FALSE); | ||
|
|
There was a problem hiding this comment.
g_return macros shouldn't be used for valid values and -1 is a valid value here.
There was a problem hiding this comment.
-1 is not a valid known value -- it's a value meaning "unknown", which this proposed alternate interface represents instead with a return code, instead of the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very conservative change that attempts to address #68.
It avoids changing the memory layout of the GMimeSignature object,
since it might accessed directly by a user who doesn't use the
function interface.
It takes a different approach to indicating a failure than the
established (time_t)-1 mechanism, to encourage safer use.
Signed-off-by: Daniel Kahn Gillmor dkg@fifthhorseman.net