Changed random timestamp used for props.key #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstejada Are you good with the change or would you like me to change something? |
jstejada
requested changes
Sep 9, 2018
cryptoads
commented
Sep 10, 2018
|
@jstejada I reverted back to the older version of node-sass. Let me know if I need to make any more changes. |
jstejada
requested changes
Oct 29, 2018
There was a problem hiding this comment.
@cryptoads looks godo to me! only final change is to remove the change to package.json and yarn.lock.
Thanks!
|
@jstejada finally pushed changes to my branch with changes to package.json and yarn.lock removed. |
jstejada
approved these changes
Jan 2, 2019
|
🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made small changes to the cloneElement function in Utils.js. Instead of using Date.now() I used getUTCMilliSeconds() and it seems to have fixed the issue for me.
I was able to reproduce the "unique-key" issue easily with the original method by adding about 25
tags.
After changes I was unable to reproduce the issue.