Skip to content

Commit

Permalink
Only show DevTools warning about unrecognized build in Chrome (facebo…
Browse files Browse the repository at this point in the history
  • Loading branch information
Juan committed Oct 15, 2021
1 parent e5f486b commit b72dc8e
Showing 1 changed file with 14 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,16 @@
declare var chrome: any;

import {__DEBUG__} from 'react-devtools-shared/src/constants';
import {getBrowserName} from './utils';
import {
EXTENSION_INSTALL_CHECK,
EXTENSION_INSTALLATION_TYPE,
INTERNAL_EXTENSION_ID,
LOCAL_EXTENSION_ID,
} from './constants';

const IS_CHROME = getBrowserName() === 'Chrome';

const UNRECOGNIZED_EXTENSION_ERROR =
'React Developer Tools: You are running an unrecognized installation of the React Developer Tools extension, which might conflict with other versions of the extension installed in your browser. ' +
'Please make sure you only have a single version of the extension installed or enabled. ' +
Expand Down Expand Up @@ -76,14 +79,17 @@ export function checkForDuplicateInstallations(callback: boolean => void) {
break;
}
case 'unknown': {
// If we don't know how this extension was built, we can't reliably detect if there
// are other installations of DevTools present.
// In this case, assume there are no duplicate exensions and show a warning about
// potential conflicts.
console.error(UNRECOGNIZED_EXTENSION_ERROR);
chrome.devtools.inspectedWindow.eval(
`console.error("${UNRECOGNIZED_EXTENSION_ERROR}")`,
);
// TODO: Support duplicate extension detection in other browsers
if (IS_CHROME) {
// If we don't know how this extension was built, we can't reliably detect if there
// are other installations of DevTools present.
// In this case, assume there are no duplicate exensions and show a warning about
// potential conflicts.
console.error(UNRECOGNIZED_EXTENSION_ERROR);
chrome.devtools.inspectedWindow.eval(
`console.error("${UNRECOGNIZED_EXTENSION_ERROR}")`,
);
}
callback(false);
break;
}
Expand Down

0 comments on commit b72dc8e

Please sign in to comment.