Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract simple table could be more efficient #62

Closed
jstockwin opened this issue Apr 8, 2020 · 0 comments · Fixed by #65
Closed

Extract simple table could be more efficient #62

jstockwin opened this issue Apr 8, 2020 · 0 comments · Fixed by #65

Comments

@jstockwin
Copy link
Owner

At the moment we're looping through the reference row and then the reference column, and computing the element which is in line with both the reference row element and the reference col element.

This means we're doing to geometry checks to work out each row len(cols) times, and the checks to work out each col len(rows) times.

We should do the geometry filtering at the start to create a list of rows and a list of cols. We can then just & the two to get the element.

This should require much less processing as you only do geometry checks len(rows) + len(cols) times, rather then len(rows) * len(cols) times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant