-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explain EXCLUDED_LANGS casing or make it case-insensitive #64
Comments
Hey @erikw, thanks for the suggestion! I wholeheartedly agree that it should be a case-insensitive check. This is a good catch. Feel free to make a PR, otherwise I can push this change at some point. |
erikw
added a commit
to erikw/github-stats
that referenced
this issue
Feb 16, 2022
It's not clear for users how the EXCLUDED_LANGS should be populated: * html,tex * HTML,TeX ? Avoid all question marks by normalizing both strings to lower case before they are compared. Fixes jstrieb/github-stats#64
erikw
added a commit
to erikw/github-stats-fork
that referenced
this issue
Feb 16, 2022
It's not clear for users how the EXCLUDED_LANGS should be populated: * html,tex * HTML,TeX ? Avoid all question marks by normalizing both strings to lower case before they are compared. Fixes jstrieb#64
erikw
added a commit
to erikw/github-stats
that referenced
this issue
Feb 16, 2022
It's not clear for users how the EXCLUDED_LANGS should be populated: * html,tex * HTML,TeX ? Avoid all question marks by normalizing both strings to lower case before they are compared. Fixes jstrieb/github-stats#64
erikw
added a commit
to erikw/github-stats-fork
that referenced
this issue
Feb 16, 2022
It's not clear for users how the EXCLUDED_LANGS should be populated: * html,tex * HTML,TeX ? Avoid all question marks by normalizing both strings to lower case before they are compared. Fixes jstrieb#64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation expects the languages to be in the same style as displayed on GitHub e.g.
My first instict when I set up
EXCLUDED_LANGS
was to make something likehtml,tex
. Not until reading the source code I saw that the code expects the exclude list to be using the same casing as GitHub has. Thus to exclude HTML and Tex files, we must writeHTML,TeX
.I propose one of these:
EXCLUDED_LANGS
to lower-case.github-stats/github_stats.py
Lines 350 to 351 in 9bcdc13
EXCLUDED_LANGS
should have languages as displayed in the generated image / as shown on the GitHub repo pageThe text was updated successfully, but these errors were encountered: