Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis in HTML Body break URL Pages Editor #1

Closed
kidGodzilla opened this issue Jun 30, 2019 · 2 comments
Closed

Emojis in HTML Body break URL Pages Editor #1

kidGodzilla opened this issue Jun 30, 2019 · 2 comments

Comments

@kidGodzilla
Copy link

kidGodzilla commented Jun 30, 2019

More of an FYI than anything.

Emojis break the html body, so other valid character sets might as well.

Seems to be this: https://stackoverflow.com/questions/30106476/using-javascripts-atob-to-decode-base64-doesnt-properly-decode-utf-8-strings

Nice project!

kidGodzilla added a commit to kidGodzilla/urlpages that referenced this issue Jun 30, 2019
Allows authoring and viewing of pages with > 8-bit characters
@benja-johnny
Copy link

HTML comment tags also cause problems, just saying.

@jstrieb
Copy link
Owner

jstrieb commented May 15, 2020

Apologies for taking nearly a year to fix this. I have just pushed an update that should address the problem. I had to write a base64 library for another project I am working on, and decided to integrate it into this project to fix issues with encoding more exotic character sets. Hopefully it works now!

@jstrieb jstrieb closed this as completed May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants