Fix respond_to? method signature
#8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Ruby 2.0.0, the Ruby interpreter now gives a warning message when `respond_to?` is used with the deprecated method signature, taking one argument. As of version 2.0.0, the second argument is `include_all`, which defaults to false. You can see this in the Ruby source [here](https://github.com/ruby/ruby/blob/ruby_2_0_0/vm_method.c#L1578-L1579). This PR adds that second parameter and defaults it to false to stop the warnings.
jsuchal
added a commit
that referenced
this pull request
Oct 7, 2015
Fix `respond_to?` method signature
|
Thanks. |
|
Awesome. Thanks for merging, @jsuchal. (Also, thanks for the great library!) Any chance I could get you to bump the version and release to rubygems? If not, no problem. Failing that, could you maybe tag the current master so I can reference it from my app without pointing to the master branch, which may change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Ruby 2.0.0, the Ruby interpreter now gives a warning message when
respond_to?is used with the deprecated method signature (taking oneargument). As of version 2.0.0, the second argument is
include_all, meaning that it should include private methods, which defaults to false. You can see this in the Ruby sourcehere. This PR adds that second parameter and defaults it to false to stop the
warnings.