Cross build for Scala 2.9 and 2.10 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* scala.StaticAnnotation went away in 2.10.x. * Use 2.9.0 so it works for all 2.9.x.
* Adds _2.9 or _2.10.0-RC2 to artifact id. When 2.10.0-final is
released, will change artifact id to _2.10.
* To build, use mvn -f pom-${scala_version}.xml. We could keep one
POM with a variable in the artifactId, but this makes Maven sad.
* Cleans up compiler warnings introduced in 2.10. Did not fuss about
feature warnings in order to keep a unified source tree.
|
LGTM. If I was feeling fun, I'd set up an sbt build to do the cross-versioning and auto generate the poems. |
jsuereth
added a commit
that referenced
this pull request
Nov 12, 2012
Cross build for Scala 2.9 and 2.10
|
Oh, as an aside, can you update a READMe file about the cross build? |
|
Yes, I was going to circle back to the docs if the approach was ruled Not Crazy. Thanks for the merge. I thought about the sbt generator too, and then I looked at my scar from building an sbt plugin in maven. That hurt mostly due to getting sbt libs in a maven repo, so this direction might be easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a separate POM for each minor version of Scala, and add it to the artifactId. Could do a _2.9.1, _2.9.2, etc., like SBT convention, but this won't be used by SBT anyway, so this is the minimum that supports binary compatibility.
Alternatively, 0.5 could just be the Scala 2.10.x release, but it's trivial to support both in case anybody enhances this.
I'll move the 2.10.0-RC2 pom to a simple _2.10 once it's final. Mainly want to get a Scalate port up and running, and this is one of our blockers.